Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: describe that simpleCellRangeToString does not work with column ranges and row ranges #1391

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Mar 7, 2024

Context

Issue #1375 should be fixed by making simpleCellRangeToString work with all types of ranges, but until we do it, I added a disclaimer to the docs.

How did you test your changes?

local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

#1375

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba requested a review from evanSe March 7, 2024 14:36
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (e32e132) to head (06f342a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1391   +/-   ##
========================================
  Coverage    97.36%   97.36%           
========================================
  Files          169      169           
  Lines        14421    14421           
  Branches      3021     3021           
========================================
  Hits         14041    14041           
  Misses         380      380           
Files Coverage Δ
src/HyperFormula.ts 99.59% <ø> (ø)

Copy link

github-actions bot commented Mar 7, 2024

Performance comparison of head (06f342a) vs base (e32e132)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A |  531.8 | 533.62 | +0.34%
                                      Sheet B | 172.49 | 171.21 | -0.74%
                                      Sheet T | 151.95 | 151.99 | +0.03%
                                Column ranges | 550.83 | 550.38 | -0.08%
Sheet A:  change value, add/remove row/column |   14.1 |  14.03 | -0.50%
 Sheet B: change value, add/remove row/column |  124.3 | 130.63 | +5.09%
                   Column ranges - add column | 154.64 | 155.06 | +0.27%
                Column ranges - without batch | 457.59 | 460.29 | +0.59%
                        Column ranges - batch | 117.65 | 119.03 | +1.17%

@sequba sequba merged commit 34d761a into develop Mar 25, 2024
23 checks passed
@sequba sequba deleted the feature/issue-1375-disclaimer branch March 25, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants