Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell value exporter #151

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Cell value exporter #151

merged 2 commits into from
Feb 10, 2020

Conversation

voodoo11
Copy link
Collaborator

@voodoo11 voodoo11 commented Feb 6, 2020

Context

One place for transforming (rounding, translating errors) cell content before pulling it from engine.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. CellError does not provide localized error value that should be displayed in a cell #48

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

swistak35
swistak35 previously approved these changes Feb 7, 2020
View reviewed changes
src/Cell.ts Outdated Show resolved Hide resolved
src/HyperFormula.ts Show resolved Hide resolved
@voodoo11
DetailedCellError and CellValueExporter
2ba6799 
use exporter to transform values before pulling out from engine
@voodoo11 voodoo11 requested a review from izulin February 10, 2020 10:23
izulin
izulin previously approved these changes Feb 10, 2020
View reviewed changes
@voodoo11 voodoo11 requested a review from izulin February 10, 2020 10:37
@voodoo11 voodoo11 merged commit 39d28be into master Feb 10, 2020
@voodoo11 voodoo11 deleted the cell-value-exporter branch February 14, 2020 09:57
@voodoo11 voodoo11 mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izulin izulin izulin approved these changes

@swistak35 swistak35 swistak35 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@voodoo11 @swistak35 @izulin