Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formula helpers and named expressions with formulas #167

Merged
merged 43 commits into from Feb 14, 2020
Merged

Formula helpers and named expressions with formulas #167

merged 43 commits into from Feb 14, 2020

Conversation

swistak35
Copy link
Contributor

Context

Described in #24

How has this been tested?

I've added tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Formula helpers #24

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

voodoo11
voodoo11 previously approved these changes Feb 14, 2020
View reviewed changes
@swistak35
Add initial version of calculateFormula()
3b971f5 
Issue: #24
@swistak35
Add test which checks whether external formula is recomputed
0242c65
@swistak35
Add possibility to change contents of external formula
f9167d3
@swistak35
Add possibility to normalize formula
b71d12c
@swistak35
Refactoring: Introduce ChangeList type
595a985
@swistak35
Add test ensuring that it works for more formulas
894d2f8
@swistak35
Refactoring: Split test suite into two
94ace93
@swistak35
Add basic validation of external formulas
6ede164
@swistak35
Add documentation
6500751
@swistak35
External formula is not valid if it has lexical errors
f5e7959
@swistak35
Literal error is ok (if that's what user want)
274844b
@swistak35
Extract NamedReferences module
bac51b1
@swistak35
Refactoring: Rename HyperFormula#calculateFormula -> HyperFormula#add…
60864d3 
…NamedExpression
@swistak35
Add ability to retrieve value of named expression by it's name
e539d36 
Temporarily changing named expression formula is forbidden, need to do
new API for that which does not use -1 sheet internal.
@swistak35
Allow to add only one expression for given name
375b0ac
@swistak35
Add assertion ensuring that NamedExpression won't contain duplicates
1674305
@swistak35
Add basic validation of named expressions
2795dc2
@swistak35
Refactoring: Rename NamedExpressionAlreadyTaken -> NamedExpressionNam…
cbcbd29 
…eIsAlreadyTaken
@swistak35
Refactoring: Extract error classes out to separate file
d4bef92 
They still belongs to the responsibility of the HyperFormula unit, but
majority of this code is just formatting the error. So I think it's
cleaner when they are in separate file.
@swistak35
Refactoring: Remove unused return value
eb25bc4
@swistak35
Refactoring: Rename ivar NamedExpressions#nextExternalFormulaId -> ne…
22a89ca 
…xtNamedExpressionRow
@swistak35
Make it possible to retrieve value of non existing named expression
ebd9936
@swistak35
Add API for removing named expressions
c75a2f2
@swistak35
Refactoring: extract NamedExpressions#buildAddress method
bb6046f
@swistak35
Refactoring: Remove magic constant
a921c8a
@swistak35
SparseStrategy will not leak memory in the long run for named express…
c7e67f8 
…ions
@swistak35
Allow again to change formulas in named expressions
34700d6
@swistak35
Refactoring
8e6b526
voodoo11
voodoo11 previously approved these changes Feb 14, 2020
View reviewed changes
@swistak35 swistak35 merged commit aa863d9 into master Feb 14, 2020
@swistak35 swistak35 deleted the rl/formula-helpers branch February 14, 2020 10:41
This was referenced Feb 21, 2020
Closed
Open
@wojciechczerniak wojciechczerniak mentioned this pull request Mar 6, 2020
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoo11 voodoo11 voodoo11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swistak35 @voodoo11