Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error propagation #185

Merged
merged 5 commits into from Feb 20, 2020
Merged

error propagation #185

merged 5 commits into from Feb 20, 2020

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Feb 20, 2020

Context

Added testcases to verify that error-propagation errors are no longer the case.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Error N/A with some operators gives wrong result #144
  2. Errors handling with some operators gives wrong result #145

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

This was referenced Feb 20, 2020
Closed
Closed
wojciechczerniak
wojciechczerniak approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing that should block the merge

LGTM 👍 Thanks for adding tests

test/interpreter/error-literals.spec.ts Outdated Show resolved Hide resolved
test/interpreter/error-literals.spec.ts Outdated Show resolved Hide resolved
test/interpreter/error-literals.spec.ts Outdated Show resolved Hide resolved
test/interpreter/error-literals.spec.ts Outdated Show resolved Hide resolved
izulin and others added 4 commits February 20, 2020 16:39
@izulin @wojciechczerniak
Update test/interpreter/error-literals.spec.ts
d82d008 
Co-Authored-By: Wojciech Czerniak <wojciech.czerniak@gmail.com>
@izulin @wojciechczerniak
Update test/interpreter/error-literals.spec.ts
d24863a 
Co-Authored-By: Wojciech Czerniak <wojciech.czerniak@gmail.com>
@izulin @wojciechczerniak
Update test/interpreter/error-literals.spec.ts
c82551c 
Co-Authored-By: Wojciech Czerniak <wojciech.czerniak@gmail.com>
@izulin @wojciechczerniak
Update test/interpreter/error-literals.spec.ts
daea105 
Co-Authored-By: Wojciech Czerniak <wojciech.czerniak@gmail.com>
@izulin izulin merged commit 27392fa into develop Feb 20, 2020
@wojciechczerniak wojciechczerniak deleted the pu/issue-144 branch February 23, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciechczerniak wojciechczerniak wojciechczerniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izulin @wojciechczerniak