Batch operations #256
Merged
Batch operations #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setCellContent: (address: SimpleCellAddress, newCellContent: RawCellContent) => void, | ||
| setCellContents: (topLeftCornerAddress: SimpleCellAddress, cellContents: RawCellContent[][] | RawCellContent) => void, |
There was a problem hiding this comment.
@swistak35 Do we need the BatchExecutor in batch method? This create sync problem and with suspendEvaluation we're using engine instance anyway. Shouldn't all (or most of) engine public APIs be available to run in batch?
There was a problem hiding this comment.
@wojciechczerniak yes, this is very possible, I just like to get to removals incrementally, but was thinking the same
swistak35
force-pushed
the
rl/batch-operations
branch
from
ca1c90b
to
480e320
Compare
We no longer have more evaluators and I don't think we will have in near future
Temporarily. I want to have unified interfaces in both CrudOperations and HyperFormula is intermediary step before removing CrudOperations.
…onIsNotSuspended All suspension code was already renamed to use "evaluation suspension" language
swistak35
force-pushed
the
rl/batch-operations
branch
from
7189892
to
60d4d77
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
How has this been tested?
Types of changes
Related issue(s):
Checklist: