time parsing

[izulin]

Context

Custom time parsing.

How has this been tested?

unit tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature or improvement (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Additional language file or change to the existing one (translations)

Related issue(s):

1. Time and DateTime types and duration #229

Checklist:

• My code follows the code style of this project,
• My change requires a change to the documentation,
• I described the modification in the CHANGELOG.md file.

[izulin]

@wojciechczerniak please see whether you like this approach to custom time and date

[wojciechczerniak]

Yup, makes sense 👍

Shouldn't we implement a sample DateTime function that should return/stringify/display a dateTime or time?

[wojciechczerniak]

Should we go with the full rename?

Suggested change

	import {DateHelper} from './DateTime'
	import {DateTimeHelper} from './DateTimeHelper'

[izulin]

there is more to this file than the Helper. At one point we might split the file into -Helper and -Default

[wojciechczerniak]

I was going to report this anyway, so maybe BTW we could fix it: dateFormat is not sufficient here. We don't have access to leapYear1900, nullDate, nullYear. My suggestion would be to pass the whole Config as an argument instead of listing them all

[izulin]

IMO we shouldn't have access to those options from the level of those functions. I specifically did a refactor, so that 'parseDate' is doing what it promises: parses a date format. The logic behind transforming date object into number is hidden in the engine and shouldn't be a part of parsing function.

[wojciechczerniak]

We do not stringify the DateTime object?

[izulin]

Yup, makes sense 👍

Shouldn't we implement a sample DateTime function that should return/stringify/display a dateTime or time?

Sorry, I meant to write that this is WIP. I implemented first half of the issue, and will proceed to the second half now.

[wojciechczerniak]

Yup, makes sense 👍
Shouldn't we implement a sample DateTime function that should return/stringify/display a dateTime or time?

Sorry, I meant to write that this is WIP. I implemented first half of the issue, and will proceed to the second half now.

OK. Let me know when it's ready for a review

[izulin]

@wojciechczerniak take a look

[izulin]

the only deviation from standard formatting (that is used in e.g. moment.js) is that moment.js uses HH and hh to distinguish between 24 and 12 hour formatting. But still, moment.js defines token 'a'. We use token 'a', which is ignored during time/parsing (since we allow for am/pm modifiers always anyway, but only at the end of the time-string). For printing, if there is token 'a', then we use 12h, and 24h system otherwise.