statistical functions #554

izulin · 2020-10-23T22:30:27Z

Context

29 statistical functions EXPON.DIST, EXPONDIST, FISHER, FISHERINV, GAMMA, GAMMA.DIST, GAMMADIST, GAMMALN, GAMMALN.PRECISE, GAMMA.INV, GAMMAINV, GAUSS, BETA.DIST, BETADIST, BETA.INV, BETAINV, BINOM.DIST, BINOMDIST, BINOM.INV, BESSELI, BESSELJ, BESSELK, BESSELY, CHIDIST, CHIINV, CHISQ.DIST, CHISQ.DIST.RT, CHISQ.INV, CHISQ.INV.RT.

How has this been tested?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature or improvement (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

My code follows the code style of this project,
My change requires a change to the documentation,
I described the modification in the CHANGELOG.md file.

codecov · 2020-10-23T22:44:33Z

Codecov Report

Merging #554 into develop will increase coverage by 0.01%.
The diff coverage is 92.51%.

@@             Coverage Diff             @@
##           develop     #554      +/-   ##
===========================================
+ Coverage    91.89%   91.91%   +0.01%     
===========================================
  Files          159      161       +2     
  Lines        31666    33491    +1825     
  Branches      2971     3130     +159     
===========================================
+ Hits         29099    30782    +1683     
- Misses        2561     2703     +142     
  Partials         6        6

Impacted Files	Coverage Δ
src/interpreter/plugin/3rdparty/bessel/bessel.ts	`84.12% <84.12%> (ø)`
src/interpreter/plugin/3rdparty/jstat/jstat.ts	`86.54% <86.54%> (ø)`
src/i18n/languages/csCZ.ts	`100.00% <100.00%> (ø)`
src/i18n/languages/daDK.ts	`100.00% <100.00%> (ø)`
src/i18n/languages/deDE.ts	`100.00% <100.00%> (ø)`
src/i18n/languages/enGB.ts	`100.00% <100.00%> (ø)`
src/i18n/languages/esES.ts	`100.00% <100.00%> (ø)`
src/i18n/languages/fiFI.ts	`100.00% <100.00%> (ø)`
src/i18n/languages/frFR.ts	`100.00% <100.00%> (ø)`
src/i18n/languages/huHU.ts	`100.00% <100.00%> (ø)`
... and 13 more

wojciechczerniak

Can you add jstat and bassel to deps https://handsontable.github.io/hyperformula/guide/dependencies.html ?

ksawery2.txt

src/interpreter/plugin/3rdparty/bessel/LICENSE

src/interpreter/plugin/StatisticalPlugin.ts

test/interpreter/function-chisq.inv.rt.spec.ts

test/interpreter/function-gamma.dist.spec.ts

test/interpreter/function-gamma.inv.spec.ts

test/interpreter/function-binom.inv.spec.ts

izulin · 2020-10-29T20:28:44Z

Can you add jstat and bassel to deps https://handsontable.github.io/hyperformula/guide/dependencies.html ?

How do I edit this?

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>

wojciechczerniak · 2020-10-29T20:47:59Z

Can you add jstat and bassel to deps https://handsontable.github.io/hyperformula/guide/dependencies.html ?

How do I edit this?

Here: https://github.com/handsontable/hyperformula/blob/master/docs/guide/dependencies.md

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>

…into pu/stat

wojciechczerniak

Functions are good, one more thing is to adjust formatting and linters a little bit.

docs/guide/dependencies.md

src/interpreter/plugin/3rdparty/bessel/bessel.ts

src/interpreter/plugin/3rdparty/jstat/jstat.ts

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>

wojciechczerniak

Thanks! 🥇

bardek8

Thanks! It's all good, I only found some small inconsistencies between our results and GS/XL.

bardek8 · 2020-10-30T20:45:16Z

test/interpreter/function-beta.dist.spec.ts

+      ['=BETA.DIST(1, 2, 3, 4, 5, 6, 7)'],
+    ])
+
+    expect(engine.getCellValue(adr('A1'))).toEqualError(detailedError(ErrorType.NA, ErrorMessage.WrongArgNumber))


GS sets the default value of cumulative to TRUE and returns 1 here.

this is some weird artefact...

bardek8 · 2020-10-30T20:47:34Z

test/interpreter/function-beta.dist.spec.ts

+      ['=BETA.DIST(0.6, 1, 1, FALSE(), 0.6, 0.7)'],
+      ['=BETA.DIST(0.7, 1, 1, FALSE(), 0.6, 0.7)'],
+    ])
+


Next inconsistency: GS returns 0 for 1st, 4th and 5th test.

those are also some internally inconsistent values for GS :)

bardek8 · 2020-10-30T20:51:35Z

test/interpreter/function-binom.inv.spec.ts

+    ])
+
+    expect(engine.getCellValue(adr('A1'))).toEqual(0)
+    expect(engine.getCellValue(adr('A2'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.ValueSmall))


GS returns 0 here

bardek8 · 2020-10-30T20:53:42Z

test/interpreter/function-binom.inv.spec.ts

+    expect(engine.getCellValue(adr('A2'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.ValueSmall))
+    //both products #1 and #2 return NUM for '=BINOM.INV(10, 0, 0.5)', which is incorrect
+    expect(engine.getCellValue(adr('A3'))).toEqual(0)
+    //both products #1 and #2 return NUM for '=BINOM.INV(10, 10, 0.5)', which is incorrect


the test is (10,1,0.5)

bardek8 · 2020-10-30T20:57:54Z

test/interpreter/function-gamma.spec.ts

+    expect(engine.getCellValue(adr('A1'))).toEqual(1)
+    expect(engine.getCellValue(adr('A2'))).toBeCloseTo(1.77245385588014, 6)
+    expect(engine.getCellValue(adr('A3')) as number / 1133278.39212948).toBeCloseTo(1, 6)
+    expect(engine.getCellValue(adr('A4'))).toBeCloseTo(-0.94530871782981, 6)


GS returns NUM

bardek8 · 2020-10-30T21:01:13Z

test/interpreter/function-beta.inv.spec.ts

+    expect(engine.getCellValue(adr('A1'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.ValueSmall))
+    expect(engine.getCellValue(adr('A2'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.ValueSmall))
+    expect(engine.getCellValue(adr('A3'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.ValueSmall))
+    expect(engine.getCellValue(adr('A4'))).toEqual(1)


XL returns NUM here

bardek8 · 2020-10-30T21:01:53Z

test/interpreter/function-binom.dist.spec.ts

+
+    expect(engine.getCellValue(adr('A1'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.ValueSmall))
+    expect(engine.getCellValue(adr('A2'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.ValueSmall))
+    expect(engine.getCellValue(adr('A3'))).toEqualError(detailedError(ErrorType.NUM, ErrorMessage.WrongOrder))


XL returns 1 here

bardek8 · 2020-10-31T00:02:34Z

Also please add to the docs/guide/known-limitations.md file a new section, called e.g. Nuances of the implemented functions with all the nuances that you found recently.

izulin added 10 commits October 22, 2020 20:12

stats

693cec4

jstat

cd87b3a

.

693fe3e

.

2da4804

.

c7a6e76

test

b99ef7e

tests

78869c5

Merge branch 'develop' into pu/stat

9658965

docs

e86eb4e

license + linter

85ddf4f

izulin requested review from wojciechczerniak and bardek8 October 23, 2020 22:30

izulin marked this pull request as draft October 23, 2020 22:31

izulin and others added 11 commits October 24, 2020 15:05

beta.dist, beta.inv

4d7764c

binomdist

fc46825

binsearch

0e6a241

docs

d9a3f50

bessel

05d03e3

.

42f1fdb

docs

2c4b8f1

linter

9390632

chisq

014ef20

.

928d7e6

Merge branch 'develop' into pu/stat

7bda78d

izulin marked this pull request as ready for review October 29, 2020 09:37

wojciechczerniak suggested changes Oct 29, 2020

View reviewed changes

.

9673d61

Update src/interpreter/plugin/StatisticalPlugin.ts

705275c

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>

izulin and others added 4 commits October 29, 2020 23:22

Update test/interpreter/function-binom.inv.spec.ts

e8a475b

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>

fixes

bc3897d

Merge branch 'pu/stat' of https://github.com/handsontable/hyperformula …

bc1cdab

…into pu/stat

.

58e1de1

izulin requested a review from wojciechczerniak October 30, 2020 10:53

izulin added 2 commits October 30, 2020 11:59

Update dependencies.md

ccd1c5d

Merge branch 'develop' into pu/stat

970edae

wojciechczerniak suggested changes Oct 30, 2020

View reviewed changes

izulin and others added 4 commits October 30, 2020 14:57

Update docs/guide/dependencies.md

98156dc

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>

Update src/interpreter/plugin/3rdparty/bessel/bessel.ts

6f24b2c

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>

Merge branch 'develop' into pu/stat

343061b

.

6b535c6

izulin requested a review from wojciechczerniak October 30, 2020 14:12

wojciechczerniak approved these changes Oct 30, 2020

View reviewed changes

bardek8 suggested changes Oct 30, 2020

View reviewed changes

izulin added 2 commits October 31, 2020 20:09

compatibility

d617870

limitations

ade53fb

izulin requested a review from bardek8 October 31, 2020 19:13

bardek8 approved these changes Oct 31, 2020

View reviewed changes

izulin merged commit 974c492 into develop Oct 31, 2020

izulin deleted the pu/stat branch October 31, 2020 21:05

This was referenced Nov 25, 2020

Add Statistical functions #160

Closed

Add Compatibility functions #152

Closed

wojciechczerniak mentioned this pull request Dec 9, 2020

Add Engineering functions #154

Closed

38 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

statistical functions #554

statistical functions #554

izulin commented Oct 23, 2020 •

edited by wojciechczerniak

codecov bot commented Oct 23, 2020 •

edited

wojciechczerniak left a comment

izulin commented Oct 29, 2020

wojciechczerniak commented Oct 29, 2020

wojciechczerniak left a comment

wojciechczerniak left a comment

bardek8 left a comment

bardek8 Oct 30, 2020

izulin Oct 31, 2020

bardek8 Oct 30, 2020

izulin Oct 31, 2020

bardek8 Oct 30, 2020

bardek8 Oct 30, 2020

bardek8 Oct 30, 2020

bardek8 Oct 30, 2020

bardek8 Oct 30, 2020

bardek8 commented Oct 31, 2020

statistical functions #554

statistical functions #554

Conversation

izulin commented Oct 23, 2020 • edited by wojciechczerniak

Context

How has this been tested?

Types of changes

Related issue(s):

Checklist:

codecov bot commented Oct 23, 2020 • edited

Codecov Report

wojciechczerniak left a comment

Choose a reason for hiding this comment

izulin commented Oct 29, 2020

wojciechczerniak commented Oct 29, 2020

wojciechczerniak left a comment

Choose a reason for hiding this comment

wojciechczerniak left a comment

Choose a reason for hiding this comment

bardek8 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bardek8 commented Oct 31, 2020

izulin commented Oct 23, 2020 •

edited by wojciechczerniak

codecov bot commented Oct 23, 2020 •

edited