Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rows/columns fixed to work with arrays #677

Merged
merged 26 commits into from May 28, 2021
Merged

rows/columns fixed to work with arrays #677

merged 26 commits into from May 28, 2021

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented May 19, 2021

Context

ROWS/COLUMNS now work with arrays

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #677 (df7fefe) into develop (b5b1717) will decrease coverage by 0.27%.
The diff coverage is 85.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #677      +/-   ##
===========================================
- Coverage    92.51%   92.23%   -0.28%     
===========================================
  Files          166      166              
  Lines        38831    39191     +360     
  Branches      3530     5363    +1833     
===========================================
+ Hits         35924    36149     +225     
- Misses        2901     3003     +102     
- Partials         6       39      +33     
Impacted Files Coverage Δ
src/parser/ParserConfig.ts 0.00% <0.00%> (ø)
src/interpreter/Interpreter.ts 51.42% <8.82%> (-3.18%) ⬇️
src/dependencyTransformers/Transformer.ts 79.35% <16.66%> (-1.04%) ⬇️
src/parser/ParserWithCaching.ts 79.60% <25.00%> (-0.88%) ⬇️
src/DependencyGraph/DependencyGraph.ts 85.95% <33.33%> (-0.21%) ⬇️
src/MatrixSize.ts 48.48% <34.88%> (-3.54%) ⬇️
src/NamedExpressions.ts 94.49% <50.00%> (-0.72%) ⬇️
src/interpreter/plugin/NumericAggregationPlugin.ts 92.16% <50.00%> (-0.26%) ⬇️
src/parser/Unparser.ts 65.27% <50.00%> (-0.44%) ⬇️
src/parser/Cache.ts 90.72% <66.66%> (-0.77%) ⬇️
... and 78 more

Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from pu/vectorization to develop May 28, 2021 12:46
@izulin izulin merged commit 3050d9f into develop May 28, 2021
@izulin izulin deleted the pu/functionfixes branch May 28, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants