Skip to content
This repository has been archived by the owner on Mar 14, 2022. It is now read-only.

Move the 'warn' helper to the repo. #151

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Move the 'warn' helper to the repo. #151

merged 1 commit into from
Dec 23, 2019

Conversation

jansiegel
Copy link
Member

Context

Since 3.1.1 all the builds contained core-js and moment.js because of an imported function from Handsontable. This also caused the .min.js UMD builds to fail.

This change moves the function to the wrapper's internal helper file to avoid future problems.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@jansiegel jansiegel merged commit 2e60cc5 into develop Dec 23, 2019
@aninde
Copy link

aninde commented Apr 15, 2020

I tested it with min.js version. It seems to works good https://jsfiddle.net/aninde/3tyk9a5c/2/ Handsontable-React 3.1.3, Handsontable 7.4.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants