Renamed dll to avoid conflict

[builder-main]

Following the way Unity does it for its own packages I renamed a conflicting dll. I believe all Roslyn Dll should get the FSR suffix as well. I could get through it if you'd like.

[handzlikchris]

thanks for PR,

makes sense. Is that still the recommended way to go around the issue?

Also - I've got some legacy support to do on non-package version (for Unity store) - where update will not offer to remove dll for users, hence they'll end up with 2 dll's that do the same.

Would that approach not break it?

[builder-main]

makes sense. Is that still the recommended way to go around the issue?

This is what you find in the official plastic SCM package for instance. Not sure where I saw how the issue was resolved on a blog post or elsewhere.

Would that approach not break it?

Pretty sure It won't break, you'll have a non used duplicate that could be safe deleted by the user, you'd probably want to add the FSR renamed dll as overrides as well.

I'll go on with the full migration if you feel it's good.

[handzlikchris]

I've read at some point that Unity wanted to do that (nasty!) but though maybe some stuff changed since then.

Yeah - if you could apply same approach to other dlls and update asmdefs that'd be great - that way we can keep it consistent

Thanks!

[builder-main]

Sorry I did not kept you informed on this, a while ago I tried to rename all of the dll, although it was not my usecase, and had runtime errors so I reverted it.

Renaming the Immutable dll was enough for me.
If anymore people face an issue with a specific Dll we could always rename it on a case to case basis.

Thanks for having merge this !