😎: Dump react-like state management #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have made a huge update 🙌! Instead of using the react-like array destructing state management, we are now just returning the instance, which is much more far better in terms of code readability and DX as the dev might need to destructure again to get the instance, which is a bad idea 👎
haneenmahd
added
documentation
haneenmahd
commented
Aug 16, 2022
lib/createState.ts
Outdated
| @@ -45,17 +41,14 @@ import type { | |||
| function createState<T>( | |||
There was a problem hiding this comment.
Maybe we could have an update for the registerEffect hook too? As we are switching style, I think it might be time for it to be removed too 👍🏻 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
createState()Description
This PR comes with a huge update 🙌!
Instead of using the react-like array destructing state management, we are now just returning the instance, which is much more far better in terms of code readability and DX as the dev might need to destructure again to get the instance, which is a bad idea 👎
Linked issues
Does this PR introduce breaking changes?
Yes.
This PR changes the way we get and set the value of state and since now, it passes out a simple instance rather than providing the getter, setter and instance as a separate elements of an array.