Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for image_screenshot plugin #488

Merged
merged 3 commits into from Feb 28, 2016
Merged

Small fixes for image_screenshot plugin #488

merged 3 commits into from Feb 28, 2016

Conversation

CyBot
Copy link
Contributor

@CyBot CyBot commented Jan 27, 2016

Now the hangupsbot directory doesn't have to be writable by the bot anymore

@nylonee
Copy link
Contributor

nylonee commented Jan 27, 2016

Nice! To confirm, tempfile is part of the main python libraries? It doesn't need to be added to the list of requirements?

@nylonee nylonee self-assigned this Jan 27, 2016
@CyBot
Copy link
Contributor Author

CyBot commented Jan 28, 2016

Yes, it's part of the standard library

@jumoog
Copy link
Contributor

jumoog commented Jan 29, 2016

you should remove the file once we are done

@CyBot
Copy link
Contributor Author

CyBot commented Jan 29, 2016

That already happens in https://github.com/CyBot/hangoutsbot/blob/master/hangupsbot/plugins/image_screenshot/__init__.py#L49

@jumoog
Copy link
Contributor

jumoog commented Jan 29, 2016

oh sorry didn't see that before ... shame on me

vigoren added a commit to vigoren/hangoutsbot that referenced this pull request Feb 12, 2016
@vigoren
Updates to the image screen shot to make it work better pull request h…
514aadc 
…angoutsbot#488
@nylonee nylonee mentioned this pull request Feb 28, 2016
Merged
@nylonee nylonee merged commit 36ebb36 into hangoutsbot:master Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nylonee nylonee

Labels
enhancement merged-into-staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CyBot @nylonee @jumoog