Fix too many recursiver errors on deeply nested alist structures #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case was crashing threads in modern sbcl, if the json was
large due to exceeding the maximum error depth
(json:encode-json-alist-to-string
(json:decode-json-from-string *json*))
* Replace direct call in the error handler with restart invokation
* fix bug where if the value of an alist-cell was an alist we wouldnt
try parsing it as one (the cdr was a cons)
* use symbol names for list encoder so that changes in the encoder
(such as tracing adding break points) show up without having to
switch that variable
Open
hankhero
added a commit
that referenced
this pull request
Nov 7, 2014
Fix too many recursiver errors on deeply nested alist structures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case was crashing threads in modern sbcl, if the json was
large due to exceeding the maximum error depth
(json:encode-json-alist-to-string
(json:decode-json-from-string json))
try parsing it as one (the cdr was a cons)
(such as tracing adding break points) show up without having to
switch that variable
This fixes issue:1