-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is json gem needed for Ruby 1.9? #20
Comments
Hello Matt, Json dependency is not required for ruby 1.9 since it is in the stdlib. However there is no way to define a conditional dependency in the gemspec. I am considering removing it anyway, everybody should use 1.9 :) |
ca1af0b removes json dependency. |
I'm still using ruby 1.8 and I ran into this issue today. I'm quite sure If you don't have plans to move to bundler, at least post a note in the docs for ruby 1.8 users, please :) |
I don't see how bundler solve this problem. If you need flickraw in your app you put something like I agree with you on the documentation. I will update this. |
My bad, bundler only handles that in development. The following code actually works: if Gem::Version.new(RUBY_VERSION.dup) <= Gem::Version.new("1.8.7")
s.add_dependency "json", ...
end I've seen this code before, but instead of |
This doesn't work : it is executed once on the machine building the gem (when you do |
When I did
gem install flickraw
, it installed the gem json-1.5.1. For Ruby 1.9,require 'json'
is supported out of the box, so is this necessary?If not, please use something like
gem "json", :platforms => [:ruby_18, :jruby, :mswin, :mingw_18]
in the Gemfile.I like to keep my gem list as clean as possible. :)
Ref: http://gembundler.com/man/gemfile.5.html
Thanks!
Matt
The text was updated successfully, but these errors were encountered: