WIP: failing test proving that inputs can't be empty
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: implement a fix
sweetleon
changed the title
inputs can't be imptyinputs can't be empty
hannahhoward
reviewed
Jan 3, 2020
src/rxreact.tsx
Outdated
| @@ -30,7 +30,7 @@ function withViewModelFactory<S, A, P extends S & ActionMap<A>>( | |||
| constructor(props: Difference<P, S & ActionMap<A>>) { | |||
| super(props); | |||
| let viewModel = viewModelFactory(this.propsObservable); | |||
| this.observableState = combineObservables(viewModel.inputs); | |||
| this.observableState = Object.keys(viewModel.inputs).length ? combineObservables(viewModel.inputs) : new Observable(); | |||
There was a problem hiding this comment.
You need an observable that emits something.
I recommend using the of constructor -- you'll need to add it to the rxjs import above
Suggested change
| this.observableState = Object.keys(viewModel.inputs).length ? combineObservables(viewModel.inputs) : new Observable(); | |
| this.observableState = Object.keys(viewModel.inputs).length ? combineObservables(viewModel.inputs) : of({}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: implement a fix