Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 7 support #18

Closed
wants to merge 1 commit into from
Closed

Laravel 7 support #18

wants to merge 1 commit into from

Conversation

BenSampo
Copy link

@BenSampo BenSampo commented Mar 3, 2020 •
edited

Laravel 7 depends on symfony/finder 5 so I've bumped the symfony/finder version

@BenSampo BenSampo mentioned this pull request Mar 3, 2020
Merged
3 tasks
@romanzipp
Copy link

Again blocked by hanneskod/readme-tester. Is this package really necessary?

@aat2703
Copy link

aat2703 commented Mar 3, 2020

What the status on Laravel 7 support?

@joelpiccoli
Copy link

Just waiting for the 7 support to upgrade my projects! o/

@MammutAlex
Copy link

Just waiting for the 7 support to upgrade my projects! o/

Me too 😔

@atymic
Copy link

atymic commented Mar 5, 2020

Again blocked by hanneskod/readme-tester. Is this package really necessary?

Think PHP 7.1 support could be dropped right, as it's out of support?

@hanneskod
Copy link
Owner

Hi everyone! A lot of activity here, sorry for the late reply. I completely agree that code testing tools should not interfere with actual dependencies. Will fix later today!

@TwilightDuck
Copy link

Hi,
I don't mean to push you but this is the only package holding me back from upgrading my application to Laravel 7.x

Do you happen to know when you can approve the request?

@hanneskod
Copy link
Owner

Fixed on branch 1.0. See #19. Released as ver 1.2.1. Let me know if you need anything else =)

@hanneskod hanneskod closed this Mar 5, 2020
@BenSampo
Copy link
Author

BenSampo commented Mar 5, 2020

Nice one, thanks @hanneskod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwilightDuck TwilightDuck TwilightDuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@BenSampo @romanzipp @aat2703 @joelpiccoli @MammutAlex @atymic @hanneskod @TwilightDuck