Improve caching in CI and CD #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
force-pushed
the
improve-caching
branch
from
8add5a7
to
6215edb
Compare
hannobraun
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Thank you, @hendrikmaus, looks good to me! (Disclaimers about my CI/CD non-expertise apply.)
I did a rebase (#391 was merged in the meantime). The PR applies cleanly, CI runs, and seems to use the right version. Merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change-set changes the
actions-rs/toolchain@v1Action temporarily to a fork that supportsrust-toolchain.tomlas intended. The issue on the upstream Action is open, but not merged yet actions-rs/toolchain#209. Once merged and released, we can switch back to the upstream Action in all workflow files.In the CD workflow, the target is now included in the cache key. In my experiments, that improved caching, especially for the apple targets. Before, the aarch apple target would run with the x86_64 apple cache.