This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Add support for rust-toolchain.toml #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boozook
approved these changes
Jan 28, 2022
Comment on lines
+23
to
33
| const toolchainPath = existsSync(overrideFile) | ||
| ? overrideFile | ||
| : existsSync(`${overrideFile}.toml`) | ||
| ? `${overrideFile}.toml` | ||
| : undefined; | ||
|
|
||
| if (!toolchainPath) { | ||
| throw new Error( | ||
| "toolchain input was not given and repository does not have a rust-toolchain file" | ||
| ); | ||
| } |
There was a problem hiding this comment.
Sorry for the delay on this, I'll address it today.
boozook
added a commit
to pontem-network/pontem
that referenced
this pull request
Feb 8, 2022
|
Tested there, works 👍 |
3 tasks
borispovod
pushed a commit
to pontem-network/pontem
that referenced
this pull request
Feb 8, 2022
* CI: use rust-toolchain in toml format, do not parse file and trust rustup & gh-action. * remove old rust-toolchain file * fix typo * temporarily using gh-action fork zephraph/toolchain with path actions-rs/toolchain#209
1 task
|
Hi, it would be good to get this merged, is there anything that I can help to move it forward? |
This was referenced May 21, 2022
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this pull request
May 22, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this pull request
May 23, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
the-mikedavis
added a commit
to the-mikedavis/helix
that referenced
this pull request
May 23, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
archseer
pushed a commit
to helix-editor/helix
that referenced
this pull request
May 23, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. #2528 covers switching back to the upstream when it includes those changes.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
We've forked actions-rs/toolchain and merged actions-rs/toolchain#209 so we can take advantage of full support of `rust-toolchain.toml`. Without that PR, the action fails because the `rustup` version built into the runners by default is too old. helix-editor#2528 covers switching back to the upstream when it includes those changes.
yvt
added a commit
to r3-os/r3
that referenced
this pull request
Aug 14, 2022
This fork includes [actions-rs/toolchain#209][1], the PR that would add support for TOML-style rustup toolchain files but has been left unmerged for seven months. [1]: actions-rs/toolchain#209
|
Hello, I am also interested in this change. I can help if something is blocking it. |
|
@mateimicu see #216 |
yvt
added a commit
to r3-os/actions-rust-toolchain
that referenced
this pull request
Nov 12, 2022
atodorov
added a commit
to gluwa/creditcoin3
that referenced
this pull request
Oct 10, 2023
b/c actions-rs/toolchain doesn't support rust-toolchain.toml, see actions-rs/toolchain#209
atodorov
added a commit
to gluwa/creditcoin3
that referenced
this pull request
Oct 10, 2023
b/c actions-rs/toolchain doesn't support rust-toolchain.toml, see actions-rs/toolchain#209
atodorov
added a commit
to gluwa/creditcoin3
that referenced
this pull request
Oct 11, 2023
b/c actions-rs/toolchain doesn't support rust-toolchain.toml, see actions-rs/toolchain#209
atodorov
added a commit
to gluwa/creditcoin3
that referenced
this pull request
Oct 11, 2023
b/c actions-rs/toolchain doesn't support rust-toolchain.toml, see actions-rs/toolchain#209
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
This matches the behavior in rustup's docs namely:
The previous implementation only supported a
rust-toolchainfile that included only the name. This is largely considered a legacy format at this point. I addedfast-tomlin order to be able to parse out thechannelvalue. Technicallychannelis mutually exclusive withpaththat can also be specified to point to a file that contains the toolchain value somewhere else, but I've left that out of this implementation.If folks stumble across this PR and need this functionality you can use @oxidecomputer's fork at https://github.com/oxidecomputer/actions-rs_toolchain until this is merged.