feat: try to publish a crate until it succeeds #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limited by a maximum number of attempts and a timeout.
hendrikmaus
commented
Jul 20, 2022
|
|
||
| if !exit_status.success() { | ||
| match exit_status.code() { | ||
| Some(code) => { |
There was a problem hiding this comment.
FYI: no need to check which code came back as there is only a single failure code https://doc.rust-lang.org/cargo/commands/cargo-publish.html#exit-status
hannobraun
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Thank you, @hendrikmaus! Looking forward to trying it out next week!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788
This change-set introduces a loop around the publish command for the crate in scope. It will repeatedly attempt to publish if the command fails. The loop is limited by a timeout as well as a maximum number of attempts.