Promote Region to an object
#1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation for promoting it to an object.
This is more preparation for turning `Region` into an object.
It has become redundant with `Face::new`. In addition, it will no longer be possible to support it, once `Region` becomes a full-blown object, as a `Handle<Region>` would be needed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm working on restoring more example models (see #1868), I'm seeing the need for operations to be implemented on
Region. Operations are only implemented for objects, andRegionwas not an object before this pull request.This alone might not be reason enough to turn
Regioninto an object (the operations API could also include non-objects), but I'm also planning some changes to how object identity is handled (no issue yet; will open one once I get the chance), and I see benefits toRegionbeing an object under this new model. So given that, and to keep the operations API consistent, I decided to promoteRegionto an object.This already includes some changes to the operations API, which were necessary to keep things working. Not making those changes and keeping
UpdateFaceas it was, caused borrow checker issues that aren't an issue by keeping things clean and introducingUpdateRegion, as I did in this pull request.