Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up approximation code #245

Merged
merged 8 commits into from Feb 23, 2022
Merged

Clean up approximation code #245

merged 8 commits into from Feb 23, 2022

Commits on Feb 23, 2022

  1. Simplify test names

    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    32fe55f View commit details
    Browse the repository at this point in the history

  2. Add dependency on map-macro 

    I'm going to use it in unit tests.
    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    0092a71 View commit details
    Browse the repository at this point in the history

  3. Prevent duplicate points in Approximation 

    This is simpler and less error-prone that what was there previously.
    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    bbfb88e View commit details
    Browse the repository at this point in the history

  4. Prevent duplicate segments in Approximation 

    This is simpler and less error-prone than what was there previously.
    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    8da1ad6 View commit details
    Browse the repository at this point in the history

  5. Refactor

    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    c8e5559 View commit details
    Browse the repository at this point in the history

  6. Validate segments on constructions 

    This addresses part of #240.

This required a modification to the approximation test suite, which had
some redundant checking code. I will follow this up with a cleanup in
the next commit, to remove the redundancy.
    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    b6cd43b View commit details
    Browse the repository at this point in the history

  7. Remove redundant code

    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    b023c94 View commit details
    Browse the repository at this point in the history

  8. Remove Approximation::validate 

    It doesn't check very much any more, after the latest round of cleanups.
What it does check, should be well-covered by the existing unit tests,
so there's not much point in keeping it around.
    @hannobraun
    hannobraun committed Feb 23, 2022
    Copy the full SHA
    cd48a7a View commit details
    Browse the repository at this point in the history