Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async/Await syntax support #121

Closed
thedrow opened this issue Sep 25, 2018 · 3 comments
Closed

Async/Await syntax support #121

thedrow opened this issue Sep 25, 2018 · 3 comments

Comments

@thedrow
Copy link

thedrow commented Sep 25, 2018

Futures 0.3 will support the Async/Await syntax.
One it reaches GA, Tokio will be next.
We should investigate what it will require of us to support the new syntax and prepare ourselves for it.

@thedrow
Copy link
Author

thedrow commented Sep 25, 2018

Seems like 0.3 alpha 3 has a compatibility layer with futures 0.1 that includes Tokio compatibility.
Maybe we should try that first?

@hannobraun
Copy link
Owner

Thank you for opening this issue!

I don't have the time to look into it right now (and likely won't have time for a while), but I agree that this is important. I'm happy to assist by reviewing reviewing pull requests or with general feedback.

Side note: There's a problem with the current stream-based API. Something to keep in mind when updating or redesigning the API.

blckngm added a commit to blckngm/inotify that referenced this issue Sep 12, 2019
Update tokio to 0.2 and futures to 0.3.

The crate is updated to the 2018 edition, so that related tests and
examples can be written in async/await.
blckngm added a commit to blckngm/inotify that referenced this issue Sep 15, 2019
Update tokio to 0.2 and futures to 0.3.

The crate is updated to the 2018 edition, so that related tests and
examples can be written in async/await.
@hannobraun
Copy link
Owner

We've had support for async/await for a while now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants