Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE file and update README #21

Merged
merged 1 commit into from Jan 13, 2021

Conversation

massand
Copy link
Contributor

@massand massand commented Jan 12, 2021

The LICENSE file is required for Linux packaging. The README has been updated to match the LICENSE file. This fixes #12.

@hannobraun
Copy link
Owner

Thank you, @massand!

Is merging this pull request enough to satisfy any Linux packaging requirements, or do I need to release a new version (that includes this LICENSE file) on crates.io?

@hannobraun hannobraun merged commit 3e4ed45 into hannobraun:master Jan 13, 2021
@massand
Copy link
Contributor Author

massand commented Jan 13, 2021

To pick up the license file, a new version would need to be published on crate.io. The latest version of the cargo tool (cargo publish or cargo package commands) should automatically pull in the LICENSE file path into crate metadata. You may also need to publish a new version of inotify and notify crates for this to be picked up, depending on version used to publish this chain of crates.

@hannobraun
Copy link
Owner

Thank you, I'll publish a new version as soon as I find some time.

There have been no breaking changes since the last release, so this can just be published as 0.1.5, which means it'll be picked up by dependencies automatically. A new inotify release should not be necessary, and I have no power over notify anyway.

@hannobraun
Copy link
Owner

Version 0.1.5 has been published.

@massand
Copy link
Contributor Author

massand commented Jan 16, 2021

@hannobraun Any plans to bump the release for inotify-rs to pick up the inotify-sys 0.1.5 crate? inotify 0.9.2 depends on inotify-sys 0.1.3.

@hannobraun
Copy link
Owner

As I said earlier, the new version will be picked up by dependencies automatically. inotify-sys = "0.1.3" is the same as inotify-sys = "^0.1.3", which means >=0.1.3, <0.2.0 (documentation).

Unless other crates in the build prevent it by using more specific version requirements, the newest version will always be chosen when running cargo update, or when running a build without an existing Cargo.lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add LICENSE file
2 participants