Remove Python 2.7 dependency from workflow #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangcpham
changed the title
|
Thanks. This seem good, but why does it still fail? I'm confused. |
|
Oh, sorry. You mentioned it, the notebooks. So that needs to be updated too. |
|
All tests passed now. Do you still want to test for Python 2.7 in the future? It seems there are some hacks around to implement Python 2.7 in setup-python. |
|
Excellent. Thanks! I don't think there is a need to keep testing for 2.7... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of June 19, GitHub workflow no longer supports Python 2.7 by setup-python (actions/setup-python#672). This pull request removes 2.7 dependency from the workflow.
Note: there is still a Python 2.7 ipynb dependency. Not sure how to work around this as it is there to test python 2.7 exclusively.