-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4 from cbm755/deps
Update README with installation instructions
- Loading branch information
Showing
1 changed file
with
8 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b1fa99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,@hanrach
I study to use the code to compute the heat during charge and discharge, for exchange, in naive method, the heat can be collected by : Qohm, Qrxn and Qrev,
in p2d_main_fn.py,
I can obtain the Ohm heat and reaction heat as below
![图片](https://user-images.githubusercontent.com/101965017/192564350-2d5f0afe-bf94-4cfa-a0ab-836b8723743d.png)
but I cannot arrive at the reversible heat. The Qrev() function prototype is Qrev(j,Tc,cM,cMp,cmax). I dont know the meaning of cM and cMp, I can usig the umat_pe to replace them.
can you help me to solve this problem.
by the way, the Ohm heat is so large ,is it reasonable?
8b1fa99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the Ohm heat. I recall the problem has a wide variety of scales... I filed #7 to help track this down