Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module #2

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Update module #2

merged 2 commits into from
Apr 3, 2023

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jan 12, 2023

Updating the module

  • manifest
  • library
  • gradle file
  • setter for options so you can asign the options later on too

ti.bottomsheet-android-2.0.0.zip

tested by @jordanbisato

@hansemannn
Copy link
Owner

Any notable changes?

@m1ga
Copy link
Contributor Author

m1ga commented Jan 12, 2023

Library:
Migrated library to Android X.
Updated dependency "AndroidUtil" to version 2.0.0.
Updated targetSdkVersion to 28.

and you can use it with current emulators again since it is including the x86_64 version now. You couldn't compile to a device/emulator.

But I only compiled it for Jordan 😄

@m1ga
Copy link
Contributor Author

m1ga commented Apr 3, 2023

added optionDlg.options = [...] so you can fill it later and not only when creating it

@hansemannn hansemannn merged commit 64604bf into hansemannn:master Apr 3, 2023
@hansemannn
Copy link
Owner

hansemannn commented Apr 3, 2023

@m1ga Thank you! Is the attached binary up to date?

@m1ga
Copy link
Contributor Author

m1ga commented Apr 4, 2023

yes, but just in case. This is the latest version:
ti.bottomsheet-android-2.0.0.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants