Fix an error at runtime for opendingux beta #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
reviewed
Dec 21, 2022
gcwconnect.py
Outdated
Comment on lines
74
to
76
| if sys.platform == dev_os: | ||
| DEBUG = True | ||
| else: DEBUG = False |
There was a problem hiding this comment.
Suggested change
| if sys.platform == dev_os: | |
| DEBUG = True | |
| else: DEBUG = False | |
| DEBUG = sys.platform == dev_os |
Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
|
Can you fix the merge conflicts? |
|
Hello, I had to add a fix because of a python version bump, would it be possible instead to pull this master into a branch like "odbeta"? |
|
I created the branch; go ahead and submit a PR for it.
Message ID: ***@***.***>
[b66123ce-18ad-425d-8c6f-54151c41505f]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, ideally we'd have this fix on top of 02ffefc
I don't think we'd want 87aa1ea as we use python3
KR