Added clickable/highlighted tables #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I'd add a rowClick attribute similar to the rowHref attribute to the _action_table template. Cool i can edit your comment |
|
Hmm. Our comments dissappeared. I might of done something wrong. |
| @@ -10,6 +10,7 @@ | |||
| :locals => { | |||
| :name => 'data', | |||
| :model => "client.#{field[:id]}.value", | |||
| :rowModule => "editInField('#{field[:id]}',$index)", | |||
There was a problem hiding this comment.
rowModal, though I'd actually prefer rowClick
|
I changed the stuff you asked for. Should I create an issue for the TODO? |
|
No, it's not important enough for an issue. |
DouglasSherk
added a commit
that referenced
this pull request
Jul 12, 2013
Added clickable/highlighted tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a bug with clickable rows not being able to click on links/buttons in the row. fixes #44