Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 Public Release #1

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open

1.0.0 Public Release #1

wants to merge 95 commits into from

Conversation

hansputera
Copy link
Owner

@hansputera hansputera commented Jul 2, 2022

TODOs

  • Stream Worker
  • [Stream Worker] Downloader Job
  • [Stream Worker] Video Combine Job
  • Readme/Documentation.
  • Reduce memory usage when sending video, and audio data.
  • Should we receive ArrayBuffer for "combine" job?

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
hansputera and others added 4 commits July 3, 2022 08:08
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@hansputera hansputera temporarily deployed to ngeworker-1 July 3, 2022 08:24 Inactive
hansputera and others added 9 commits July 3, 2022 08:51
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@hansputera
Copy link
Owner Author

hansputera commented Jul 11, 2022

Information 5ebe874, and 2fc8928

Now, the job downloader returns the url location of the file. I think we can reduce memory usage here, it's better than returning an ArrayBuffer.

Job List

  • Stream
  • Stream-Two

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@hansputera hansputera temporarily deployed to ngeworker-1 July 11, 2022 11:53 Inactive
Signed-off-by: GitHub <noreply@github.com>
@hansputera hansputera temporarily deployed to ngeworker-1 July 17, 2022 00:14 Inactive
Signed-off-by: GitHub <noreply@github.com>
@hansputera hansputera temporarily deployed to ngeworker-1 July 17, 2022 00:42 Inactive
@hansputera hansputera temporarily deployed to ngeworker-1 July 17, 2022 05:16 Inactive
@hansputera
Copy link
Owner Author

After looking at piscina_workers/stream-two#combine, I think we need to (only) accept the file URL rather than ArrayBuffer. Because, we need to reduce memory usage, between the client, and the server. So, we can download it (URL file), and not save it.

  1. If the host URL of the file is the same as the current project ip/domain, we should check the file in the 'downloads' folder.
  2. If the file is not in the 'downloads' folder, we must download it. (Don't keep it)
  3. After the downloading process is complete, we can continue the merging progress.

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@hansputera hansputera temporarily deployed to ngeworker-1 July 18, 2022 12:55 Inactive
@hansputera hansputera temporarily deployed to ngeworker-1 August 6, 2022 08:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant