Skip to content

Commit

Permalink
ath79: fix various dts warnings
Browse files Browse the repository at this point in the history 
ar9344_openmesh_mr600-v1.dts:40.10-44.5: Warning (gpios_property):
/leds-ath9k/wifi2g: Missing property '#gpio-cells' in node
/ahb/pcie-controller@180c0000/wifi@0,0 or bad phandle
=> added gpio-controller + #gpio-cells

qca955x_zyxel_nbg6x16.dtsi:121.3-13: Warning (reg_format):
/ahb/usb@1b000000/port@1:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
../dts/qca955x_zyxel_nbg6x16.dtsi:131.3-13: Warning (reg_format):
/ahb/usb@1b400000/port@1:reg: property has invalid length (4 bytes)
(#address-cells == 2, #size-cells == 1)
qca955x_zyxel_nbg6x16.dtsi:120.20-123.4: Warning (avoid_default_addr_size):
/ahb/usb@1b000000/port@1: Relying on default #address-cells value
=> ath79's usb-nodes are missing the address- and size-cells properties.
These are needed for usb led trigger support.

ar7242_ubnt_sw.dtsi:54.4-14: Warning (reg_format): /gpio_spi/gpio_spi@0:reg:
property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
=> the #address-cells and #size-cells had to be nudged.

qca9531_dlink_dch-g020-a1.dts:19.6-39.4: Warning (i2c_bus_bridge):
/i2c: incorrect #size-cells for I2C bus
=> #size-cells = <0>;

Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
  • Loading branch information
@chunkeey
chunkeey committed Dec 10, 2021
1 parent 03c0049 commit b2aca5a
Show file tree
Hide file tree
Showing 13 changed files with 45 additions and 5 deletions.
6 changes: 6 additions & 0 deletions target/linux/ath79/dts/ar7100.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@
has-synopsys-hc-bug;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

usb1: usb@1c000000 {
Expand All @@ -159,6 +162,9 @@
phys = <&usb_phy>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

spi: spi@1f000000 {
Expand Down
3 changes: 3 additions & 0 deletions target/linux/ath79/dts/ar7240.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
phys = <&usb_phy>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};
};

Expand Down
3 changes: 3 additions & 0 deletions target/linux/ath79/dts/ar7241.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
phys = <&usb_phy>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};
};

Expand Down
3 changes: 3 additions & 0 deletions target/linux/ath79/dts/ar7242.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
phys = <&usb_phy>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};
};

Expand Down
5 changes: 3 additions & 2 deletions target/linux/ath79/dts/ar7242_ubnt_edgeswitch-8xp.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,12 @@

ethernet-switch@1e {
compatible = "brcm,bcm53128";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x1e>;

ports {
#address-cells = <1>;
#size-cells = <0>;

port0@0 {
reg = <0>;
label = "lan1";
Expand Down
4 changes: 2 additions & 2 deletions target/linux/ath79/dts/ar7242_ubnt_sw.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@

gpio_spi {
compatible = "spi-gpio";
#address-cells = <0x1>;
ranges;
#address-cells = <1>;
#size-cells = <0>;

sck-gpios = <&gpio 16 GPIO_ACTIVE_HIGH>;
mosi-gpios = <&gpio 15 GPIO_ACTIVE_HIGH>;
Expand Down
3 changes: 3 additions & 0 deletions target/linux/ath79/dts/ar9330.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@
phys = <&usb_phy>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

spi: spi@1f000000 {
Expand Down
3 changes: 3 additions & 0 deletions target/linux/ath79/dts/ar9344_openmesh_mr600.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@
nvmem-cells = <&macaddr_art_0>;
nvmem-cell-names = "mac-address";
mac-address-increment = <8>;

gpio-controller;
#gpio-cells = <2>;
};
};

Expand Down
3 changes: 3 additions & 0 deletions target/linux/ath79/dts/ar934x.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@
phys = <&usb_phy>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

nand: nand@1b000200 {
Expand Down
2 changes: 1 addition & 1 deletion target/linux/ath79/dts/qca9531_dlink_dch-g020-a1.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
i2c {
compatible = "i2c-gpio";
#address-cells = <1>;
#size-cells = <1>;
#size-cells = <0>;

sda-gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
scl-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
Expand Down
3 changes: 3 additions & 0 deletions target/linux/ath79/dts/qca953x.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,9 @@
phys = <&usb_phy>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

spi: spi@1f000000 {
Expand Down
6 changes: 6 additions & 0 deletions target/linux/ath79/dts/qca955x.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@
phys = <&usb_phy0>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

usb1: usb@1b400000 {
Expand All @@ -283,6 +286,9 @@
phys = <&usb_phy1>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

nand: nand@1b800200 {
Expand Down
6 changes: 6 additions & 0 deletions target/linux/ath79/dts/qca956x.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@
phys = <&usb_phy0>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

usb1: usb@1b400000 {
Expand All @@ -219,6 +222,9 @@
phys = <&usb_phy1>;

status = "disabled";

#address-cells = <1>;
#size-cells = <0>;
};

spi: spi@1f000000 {
Expand Down

0 comments on commit b2aca5a

Please sign in to comment.