Handle kable object that includes extra stuff #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My
tables
package has atoKable
function so that it can produceoutput to be modified by
kableExtra
. I just noticed that it isn'tworking any more, and I've narrowed down the issue to the following kind
of example:
If you look at the HTML code in
kab
, it's a<style> ... </style>
blockfollowed by a
<table> ... </table>
block, but inkab2
, the table is dropped. This happens whenhtmlTable_styling
converts its input to XML: it assumes that the input is always just one block containing the table.The current PR drops this assumption. It looks through the XML for the first table, and just copies everything earlier or later into the final
htmlTable_styling
output.