Protect the code in case xml_tpart() returns NULL #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xml_tpart() calls return NULL. This should never happen for the "tbody" calls, but can happen for "thead" when tables are produced from a list of dataframes.
Still has consistency issues. Merge branch 'master' into protect_xml # Conflicts: # R/util.R
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should never be a NULL result for the "tbody" calls, but it can happen for "thead" when tables are produced from a list of dataframes.
This PR protects both, but it needs some work. It no longer produces errors as described in #699, but it produces inconsistent results for LaTeX and HTML. For example, this code:
highlights the whole first table in HTML but only the upper left cell in PDF, and this code
highlights nothing with a warning in HTML, but highlights the first row of the first table in PDF. I don't know which is the correct behaviour.