Remove event parameter #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"event" is payload parameter used to subscribe or unsubscribe to/from event notification. e.g. controller sends "event:true" to the HAP accessory if it wants to get event notifications.
it is unclear from the specification whether it should be sent with accessory description or not. it is marked as optional. Java-HAP was always sending it with the value "false".
however, the recent version of home app stops working if this parameter is in the payload for some accessory types, e.g. ColorTemperature. (reported here openhab/openhab-addons#9799 and here https://community.openhab.org/t/homekit-color-temperature-with-hue-bulbs/105658). I could also re-produce this behaviour.
this PR removes "event" parameter from the payload.