You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Its hard to say. I wanted to post here incase this was already known. Essentially We use hapi-swagger to generate our swagger json. Recently I upgraded hapi-swagger from 15.0.0 to 16.0.1. We have our environments generating the swagger json when navigating to /swagger.json. This all works but I noticed the time it takes now when hitting the url (or hitting the /swagger.json route via api call is about 30% slower in 16.x with no other changes other than upgrading this package. This dependency was updated in isolation so I am fairly confident the change lies in here but it's hard to say where the issue may be. If this isnt the right forum please let me know.
(describe your issue here, include example route or joi schemas)
constserver.routes({...})
Expected Behavior
(write what you thought would happen)
Actual Behavior
(write what happened)
Reproducible Demo
Ill try and work on one. But its possible if you just use console.time benchmarking on a call to the generated swagger via this library you'd see the speed diff.
The text was updated successfully, but these errors were encountered:
Issue
Environment
npx envinfo --npmPackages '*hapi*' --binaries
Binaries:
Node: 18.16.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 9.7.1 - /usr/local/bin/npm
Watchman: 2023.02.20.00 - /opt/homebrew/bin/watchman
npmPackages:
hapi-auth-jwt2: 10.4.0 => 10.4.0
hapi-swagger: 16.0.1 => 15.0.0
(paste the output of the command here)
Steps to Reproduce
Its hard to say. I wanted to post here incase this was already known. Essentially We use
hapi-swagger
to generate our swagger json. Recently I upgraded hapi-swagger from 15.0.0 to 16.0.1. We have our environments generating the swagger json when navigating to/swagger.json
. This all works but I noticed the time it takes now when hitting the url (or hitting the /swagger.json route via api call is about 30% slower in 16.x with no other changes other than upgrading this package. This dependency was updated in isolation so I am fairly confident the change lies in here but it's hard to say where the issue may be. If this isnt the right forum please let me know.(describe your issue here, include example
route
or joi schemas)Expected Behavior
(write what you thought would happen)
Actual Behavior
(write what happened)
Reproducible Demo
Ill try and work on one. But its possible if you just use console.time benchmarking on a call to the generated swagger via this library you'd see the speed diff.
The text was updated successfully, but these errors were encountered: