Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check before adding a required field to the list #810

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

umutuzgur
Copy link
Contributor

@umutuzgur umutuzgur commented Jul 2, 2023

Check if a field is already added to the required list

@robmcguinness
Copy link
Collaborator

@umutuzgur can you add small test?

@umutuzgur
Copy link
Contributor Author

Hey @robmcguinness, could you guide me where to add it? I'm not familiar with the repo, I was just trying to fix an issue we have since we upgraded the dep to version 16

@robmcguinness
Copy link
Collaborator

@umutuzgur
Copy link
Contributor Author

Thanks. I still don't really know why we have the field twice in the required list but we have it after I upgraded from v14 to v16. I will add a test tomorrow after I figure out why

@umutuzgur
Copy link
Contributor Author

@robmcguinness done!

@robmcguinness robmcguinness merged commit a50412e into hapi-swagger:master Jul 3, 2023
6 checks passed
@umutuzgur umutuzgur deleted the patch-1 branch July 3, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants