feat: allow formatting for authentication access elements #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmcguinness
approved these changes
Nov 4, 2023
|
@Marsup fine either way. we can follow up with another PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I found myself needing the same thing as #669, and I couldn't work around it on hapi's side, so I decided to go for an implementation that I hope will fit anyone's needs. Since this is so specific to hapi, I don't think there's a canonical way to present this kind of information, so a function hook seems best so that everyone can format it in any shape or form.
The only question I may have is: would it be worth having a default implementation of this setting (the one I used in examples and tests?), or is it fine to just not represent this information like currently?