Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServerAddressStrategy that deals with proxied requests #138

Closed
wdebeau1 opened this issue Mar 30, 2015 · 2 comments
Closed

Add ServerAddressStrategy that deals with proxied requests #138

wdebeau1 opened this issue Mar 30, 2015 · 2 comments

Comments

@wdebeau1
Copy link
Collaborator

If an incoming request goes through a proxy server, IncomingAddressStrategy will use the final address in any urls it makes. This will normally result in resource references and ids that aren't readable to the client, since presumably the final server is behind a firewall somewhere.

It'd be useful to have an address strategy that uses x-forarded-host to determine whether a request had been proxied, and if so, use the host as specified by the client.

wdebeau1 pushed a commit that referenced this issue Mar 30, 2015
wdebeau1 pushed a commit that referenced this issue Mar 31, 2015
jamesagnew added a commit that referenced this issue Apr 2, 2015
@jamesagnew
Copy link
Collaborator

Just wanted to comment: this is really nicely done, what a good idea.

@jvitrifork
Copy link
Contributor

just what I needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants