Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource contents are written to logs on subscription failure #4142

Closed
epeartree opened this issue Oct 14, 2022 · 0 comments · Fixed by #4143
Closed

Resource contents are written to logs on subscription failure #4142

epeartree opened this issue Oct 14, 2022 · 0 comments · Fixed by #4143
Assignees

Comments

@epeartree
Copy link
Collaborator

Description
Upon hitting a subscription delivery failure, we currently log the failing payload which could be considered PHI. To avoid this risk we should avoid logging payloads.

To Reproduce
Steps to reproduce the behavior:

  1. Create a SubscriptionDeliveringRestHookSubscriber;
  2. Create and submit subscription with a non existing endpoint to simulate either network/connection failure;
  3. Create a patient resource matching the subscription;
  4. The resulting log will contain fields from the resource which could be considered PHI.

Expected behavior
Resource contents should not be written to logs on subscription failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant