SubscriptionTopic part3 #4817
Merged
SubscriptionTopic part3 #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fil512
commented
May 4, 2023
•
fil512
commented
- Introduce IBaseResource.isDeleted() method and convert code to use it
- Add subscription_topic_troubleshooting log
- No longer rely on ResourceGoneException to detect deleted subscription. Instead check isDeleted().
- Demote unexpected exceptions in HapiTransactionService from error to debug since these exceptions are expected e.g. when checking if a resource has been deleted by catching a ResourceGoneException
jmarchionatto
approved these changes
May 9, 2023
...ocs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_8_0/4817-deleted-resource-detection.yaml
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Show resolved
Hide resolved
hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/subscription/model/CanonicalSubscription.java
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4817 +/- ##
============================================
+ Coverage 81.32% 83.13% +1.80%
- Complexity 23650 25293 +1643
============================================
Files 1425 1542 +117
Lines 86399 92274 +5875
Branches 11677 12313 +636
============================================
+ Hits 70265 76710 +6445
+ Misses 10947 10135 -812
- Partials 5187 5429 +242 ☔ View full report in Codecov by Sentry. |
davidraeside
pushed a commit
that referenced
this pull request
May 15, 2023
* Force Verify tests * wip * merge troubleshooting rel_6_6 troubleshooting changes * fix ITs (#4809) * fix RestHookTestR5IT * fix intermittent --------- Co-authored-by: Ken Stevens <ken@smilecdr.com> * post-merge cleanup * fix test * fix mock test * fix wiring * fix mock test * fix test * use IBaseResource.isDeleted() * fixmes * cleanup * change log --------- Co-authored-by: Tadgh <garygrantgraham@gmail.com> Co-authored-by: Ken Stevens <ken@smilecdr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.