Support of method chaining for DateRangeParameter #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed the methods setUpperBound() and setLowerBound() to return this, supporting method chaining. - changed the order in which the state of a DateRangeParam instance got first modified and then verified. - renamed the private method validateAndThrowDataFormatExceptionIfInvalid() to validateAndSet(DateParam, DateParam). - replaced the methods haveLowerBound() and haveUpperBound() with the stateless method hasBound(DateParam).
|
Looks great! Thanks! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IQueryParameterXXXimplementations I changed the methodsvoid setUpperBound()andDateRangeParam setLowerBound()toDateRangeParam setUpperBound()andvoid setLowerBound()supporting method chaining.DateRangeParaminstance got first modified and then verified.validateAndThrowDataFormatExceptionIfInvalid()tovalidateAndSet(DateParam, DateParam).boolean haveLowerBound()andboolean haveUpperBound()with the stateless methodboolean hasBound(DateParam).