Validation server exception when local reference absent #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darktyco
added a commit
to darktyco/hapi-fhir
that referenced
this pull request
Mar 6, 2018
… when no data changes
hdconradi
force-pushed
the
validation-server-exception-when-local-reference-absent
branch
from
1fae3ba
to
aa4342b
Compare
|
Rebased to the state after the R4 sync. |
added 3 commits
April 3, 2018 23:09
Currently an invalid local reference causes an InternalErrorException caused by: FHIRException: Resource resolution services not provided. The validation should instead return normally and contain an error message.
Currently an invalid local reference causes an InternalErrorException caused by: FHIRException: Resource resolution services not provided. The validation should instead return normally and contain an error message.
'fetcher == null' is ok for a local reference. Unfortunately, there are now two messages with the same meaning: - one from the ProfileValidation - one from the code in this location
hdconradi
force-pushed
the
validation-server-exception-when-local-reference-absent
branch
from
aa4342b
to
b2107ba
Compare
|
Rebased after 3.3 |
|
Thanks for the PR! This looks great. It has been merged and synced upstream. |
hdconradi
deleted the
validation-server-exception-when-local-reference-absent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an invalid local reference causes an InternalErrorException caused by: FHIRException: Resource resolution services not provided.
The validation should instead return normally and contain an error message.
This pull request fixes this error by allowing
fetcher==nullin case of local references.Unfortunately, there are now two error messages with the same meaning: