3153 update unknowncodesystemwarningvallidationsupport to have configurable severities #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #3153 |
|
Codecov Report
@@ Coverage Diff @@
## master #3155 +/- ##
============================================
- Coverage 82.76% 82.76% -0.01%
- Complexity 20057 20064 +7
============================================
Files 1346 1346
Lines 72213 72235 +22
Branches 10885 10886 +1
============================================
+ Hits 59769 59785 +16
- Misses 8270 8272 +2
- Partials 4174 4178 +4
Continue to review full report at Codecov.
|
tadgh
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Approved pending a few minor things noted in comments. One question though, does this need a version bump? Does the change in this MR actually break the API surface? Far as I can tell you changed some implementation details, but didn't break the API. Let me know if I'm wrong.
Nice work!
| @@ -162,11 +162,12 @@ public void testValidateCodeInValueSetWithUnknownCodeSystem_FailValidation() { | |||
| } | |||
|
|
|||
| /** | |||
| * By default an unknown code system should fail vaildation | |||
| * By default, an unknown code system should fail validation | |||
...a/org/hl7/fhir/common/hapi/validation/support/UnknownCodeSystemWarningValidationSupport.java
Show resolved
Hide resolved
| @Override | ||
| public CodeValidationResult validateCode(ValidationSupportContext theValidationSupportContext, ConceptValidationOptions theOptions, String theCodeSystem, String theCode, String theDisplay, String theValueSetUrl) { | ||
| // filters out error/fatal | ||
| if (!canValidateCodeSystem(theValidationSupportContext, theCodeSystem)) { |
There was a problem hiding this comment.
I'd love a bit more context about this. It seems that if this returns false, we just return a null CodeValidationResult, (which I guess means its fine and valid?) But when I read the code for canValidateCodeSystem I see this:
if (!allowNonExistentCodeSystems()) {
return false;
}
Should this not be a failure, if it is set to not allow non-existent code systems? Or is this handled by another part of validation?
| case FATAL: | ||
| return false; | ||
| default: | ||
| ourLog.info("Unknown issue severity " + myNonExistentCodeSystemSeverity.name() |
There was a problem hiding this comment.
style nitpick: move default to the bottom of the switch.
| } | ||
| } | ||
|
|
||
| private boolean canValidateCodeSystem(ValidationSupportContext theValidationSupportContext, |
There was a problem hiding this comment.
javadocs for the private methods would be helpful to future devs (though this code mostly documents itself)
|
|
||
| // Invalid code | ||
| obs.setValue(new Quantity().setSystem("http://cs").setCode("code99").setValue(123)); | ||
| oo = validateAndReturnOutcome(obs); | ||
| encoded = encode(oo); | ||
| ourLog.info(encoded); | ||
| assertEquals("No issues detected during validation", oo.getIssueFirstRep().getDiagnostics(), encoded); | ||
| assertTrue(oo.getIssueFirstRep().getDiagnostics().contains("No issues detected during validation")); |
There was a problem hiding this comment.
I'd love to see maybe one more test just covering a few of the lines considered uncovered by codecov in your implementation. This is a high value fix so it feels worthwhile to write another test to check the other cases.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| type: fix | |||
| issue: 3153 | |||
There was a problem hiding this comment.
Since I know there happens to be a related jira issue for this, could you possibly add:
jira: SMILE-XXXX below the issue line? this will allow our automation tools to wire them together.
TipzCM
deleted the
3153-update-unknowncodesystemwarningvallidationsupport-to-have-configurable-severities
branch
tadgh
pushed a commit
that referenced
this pull request
Nov 30, 2021
…urable severities (#3155) * 3153 updating the unknowncodesystemwarningvalidationsupport class * 3153 updating version for smile * 3153 update broken tests * 3153 adding log * 3153 cleanup * 3153 cleanup Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local>
tadgh
added a commit
that referenced
this pull request
Dec 9, 2021
* 3138 externalized binary packages (#3139) * Add test and impl * Add changelog * Fix test * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_6_0/3138-support-externalized-binaries.yaml * add beans to test configs * Typo * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/IBinaryStorageSvc.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/NullBinaryStorageSvcImpl.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * 3131 - Added support for the lookup operation in the Remote Terminology code (#3134) * Remove leading underscores from identifiers (#3146) * Version bump * License files * version.yaml * Add executeRawSql() method to Migrator (#3183) * Add implementation, add test * Add javadoc * Add another helper function * Bump version * 3153 update unknowncodesystemwarningvallidationsupport to have configurable severities (#3155) * 3153 updating the unknowncodesystemwarningvalidationsupport class * 3153 updating version for smile * 3153 update broken tests * 3153 adding log * 3153 cleanup * 3153 cleanup Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info * Avoid creating ResourcePersistentId for placeholder resources with null ID (#3158) * Add check before mapping storage ID to resource ID in TransactionDetails. * Add change log. * Changed to instead prevent creation of ResourcePersistentId with null ID value. * Changed to instead prevent ResourcePersistentId being created with null resource ID. Co-authored-by: ianmarshall <ian@simpatico.ai> * Fix bug loading packages in non-database mode (#3199) * Add implementation * Add changelog * Add backports * 3164 updating code review points (#3165) * 3164 updating code review points * 3164 updating code review points Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add executeRawSqlStub (#3203) Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> * Add new version * begin with failing test * fix bug * change log * change log * Add backport informationm * begin with failing test * fix issue * change log * code review * Add backport info. Add folder * fixed * Add test * Update test * Add backport info * Add 5.5.4 * Remove jpaconstants Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: TipzCM <leif.stawnyczy@gmail.com> Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> Co-authored-by: IanMMarshall <49525404+IanMMarshall@users.noreply.github.com> Co-authored-by: ianmarshall <ian@simpatico.ai> Co-authored-by: Joanne Mendoza <joannemmendoza@gmail.com> Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: katie_smilecdr <katie@smilecdr.com>
jamesagnew
pushed a commit
that referenced
this pull request
Jan 6, 2022
* 3138 externalized binary packages (#3139) * Add test and impl * Add changelog * Fix test * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_6_0/3138-support-externalized-binaries.yaml * add beans to test configs * Typo * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/IBinaryStorageSvc.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/NullBinaryStorageSvcImpl.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * 3131 - Added support for the lookup operation in the Remote Terminology code (#3134) * Remove leading underscores from identifiers (#3146) * Version bump * License files * version.yaml * Add executeRawSql() method to Migrator (#3183) * Add implementation, add test * Add javadoc * Add another helper function * Bump version * 3153 update unknowncodesystemwarningvallidationsupport to have configurable severities (#3155) * 3153 updating the unknowncodesystemwarningvalidationsupport class * 3153 updating version for smile * 3153 update broken tests * 3153 adding log * 3153 cleanup * 3153 cleanup Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info * Avoid creating ResourcePersistentId for placeholder resources with null ID (#3158) * Add check before mapping storage ID to resource ID in TransactionDetails. * Add change log. * Changed to instead prevent creation of ResourcePersistentId with null ID value. * Changed to instead prevent ResourcePersistentId being created with null resource ID. Co-authored-by: ianmarshall <ian@simpatico.ai> * Fix bug loading packages in non-database mode (#3199) * Add implementation * Add changelog * Add backports * 3164 updating code review points (#3165) * 3164 updating code review points * 3164 updating code review points Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add executeRawSqlStub (#3203) Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> * Add new version * begin with failing test * fix bug * change log * change log * Add backport informationm * begin with failing test * fix issue * change log * code review * Add backport info. Add folder * fixed * Add test * Update test * Add backport info * Bump minor version * 3170 language portion of language code is case insensitive (#3171) * 3170 language portion of language code is case insensitive * 3170 adding changelog * 3170 house keeping Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info: * Add version enum * Remove worthless import Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: TipzCM <leif.stawnyczy@gmail.com> Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> Co-authored-by: IanMMarshall <49525404+IanMMarshall@users.noreply.github.com> Co-authored-by: ianmarshall <ian@simpatico.ai> Co-authored-by: Joanne Mendoza <joannemmendoza@gmail.com> Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: katie_smilecdr <katie@smilecdr.com>
tadgh
added a commit
that referenced
this pull request
Apr 4, 2022
* 3138 externalized binary packages (#3139) * Add test and impl * Add changelog * Fix test * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_6_0/3138-support-externalized-binaries.yaml * add beans to test configs * Typo * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/IBinaryStorageSvc.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/NullBinaryStorageSvcImpl.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * 3131 - Added support for the lookup operation in the Remote Terminology code (#3134) * Remove leading underscores from identifiers (#3146) * Version bump * License files * version.yaml * Add executeRawSql() method to Migrator (#3183) * Add implementation, add test * Add javadoc * Add another helper function * Bump version * 3153 update unknowncodesystemwarningvallidationsupport to have configurable severities (#3155) * 3153 updating the unknowncodesystemwarningvalidationsupport class * 3153 updating version for smile * 3153 update broken tests * 3153 adding log * 3153 cleanup * 3153 cleanup Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info * Avoid creating ResourcePersistentId for placeholder resources with null ID (#3158) * Add check before mapping storage ID to resource ID in TransactionDetails. * Add change log. * Changed to instead prevent creation of ResourcePersistentId with null ID value. * Changed to instead prevent ResourcePersistentId being created with null resource ID. Co-authored-by: ianmarshall <ian@simpatico.ai> * Fix bug loading packages in non-database mode (#3199) * Add implementation * Add changelog * Add backports * 3164 updating code review points (#3165) * 3164 updating code review points * 3164 updating code review points Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add executeRawSqlStub (#3203) Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> * Add new version * begin with failing test * fix bug * change log * change log * Add backport informationm * begin with failing test * fix issue * change log * code review * Add backport info. Add folder * fixed * Add test * Update test * Add backport info * Bump minor version * 3170 language portion of language code is case insensitive (#3171) * 3170 language portion of language code is case insensitive * 3170 adding changelog * 3170 house keeping Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info: * Add version enum * Bump hapi version to 5.6.3 * Add version enum * Add changelog folder and version.yaml * Patch vulnerability, add changelog * Add new version * Remove test Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: TipzCM <leif.stawnyczy@gmail.com> Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> Co-authored-by: IanMMarshall <49525404+IanMMarshall@users.noreply.github.com> Co-authored-by: ianmarshall <ian@simpatico.ai> Co-authored-by: Joanne Mendoza <joannemmendoza@gmail.com> Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: katie_smilecdr <katie@smilecdr.com>
jkiddo
pushed a commit
to trifork/hapi-fhir
that referenced
this pull request
Apr 19, 2022
* 3138 externalized binary packages (hapifhir#3139) * Add test and impl * Add changelog * Fix test * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_6_0/3138-support-externalized-binaries.yaml * add beans to test configs * Typo * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/IBinaryStorageSvc.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/NullBinaryStorageSvcImpl.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * 3131 - Added support for the lookup operation in the Remote Terminology code (hapifhir#3134) * Remove leading underscores from identifiers (hapifhir#3146) * Version bump * License files * version.yaml * Add executeRawSql() method to Migrator (hapifhir#3183) * Add implementation, add test * Add javadoc * Add another helper function * Bump version * 3153 update unknowncodesystemwarningvallidationsupport to have configurable severities (hapifhir#3155) * 3153 updating the unknowncodesystemwarningvalidationsupport class * 3153 updating version for smile * 3153 update broken tests * 3153 adding log * 3153 cleanup * 3153 cleanup Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info * Avoid creating ResourcePersistentId for placeholder resources with null ID (hapifhir#3158) * Add check before mapping storage ID to resource ID in TransactionDetails. * Add change log. * Changed to instead prevent creation of ResourcePersistentId with null ID value. * Changed to instead prevent ResourcePersistentId being created with null resource ID. Co-authored-by: ianmarshall <ian@simpatico.ai> * Fix bug loading packages in non-database mode (hapifhir#3199) * Add implementation * Add changelog * Add backports * 3164 updating code review points (hapifhir#3165) * 3164 updating code review points * 3164 updating code review points Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add executeRawSqlStub (hapifhir#3203) Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> * Add new version * begin with failing test * fix bug * change log * change log * Add backport informationm * begin with failing test * fix issue * change log * code review * Add backport info. Add folder * fixed * Add test * Update test * Add backport info * Bump minor version * 3170 language portion of language code is case insensitive (hapifhir#3171) * 3170 language portion of language code is case insensitive * 3170 adding changelog * 3170 house keeping Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info: * Add version enum * Bump hapi version to 5.6.3 * Add version enum * Add changelog folder and version.yaml * Patch vulnerability, add changelog * Add new version * Remove test Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: TipzCM <leif.stawnyczy@gmail.com> Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> Co-authored-by: IanMMarshall <49525404+IanMMarshall@users.noreply.github.com> Co-authored-by: ianmarshall <ian@simpatico.ai> Co-authored-by: Joanne Mendoza <joannemmendoza@gmail.com> Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: katie_smilecdr <katie@smilecdr.com>
tadgh
added a commit
that referenced
this pull request
Jul 12, 2022
* 3138 externalized binary packages (#3139) * Add test and impl * Add changelog * Fix test * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_6_0/3138-support-externalized-binaries.yaml * add beans to test configs * Typo * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/IBinaryStorageSvc.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/NullBinaryStorageSvcImpl.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * 3131 - Added support for the lookup operation in the Remote Terminology code (#3134) * Remove leading underscores from identifiers (#3146) * Version bump * License files * version.yaml * Add executeRawSql() method to Migrator (#3183) * Add implementation, add test * Add javadoc * Add another helper function * Bump version * 3153 update unknowncodesystemwarningvallidationsupport to have configurable severities (#3155) * 3153 updating the unknowncodesystemwarningvalidationsupport class * 3153 updating version for smile * 3153 update broken tests * 3153 adding log * 3153 cleanup * 3153 cleanup Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info * Avoid creating ResourcePersistentId for placeholder resources with null ID (#3158) * Add check before mapping storage ID to resource ID in TransactionDetails. * Add change log. * Changed to instead prevent creation of ResourcePersistentId with null ID value. * Changed to instead prevent ResourcePersistentId being created with null resource ID. Co-authored-by: ianmarshall <ian@simpatico.ai> * Fix bug loading packages in non-database mode (#3199) * Add implementation * Add changelog * Add backports * 3164 updating code review points (#3165) * 3164 updating code review points * 3164 updating code review points Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add executeRawSqlStub (#3203) Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> * Add new version * begin with failing test * fix bug * change log * change log * Add backport informationm * begin with failing test * fix issue * change log * code review * Add backport info. Add folder * fixed * Add test * Update test * Add backport info * Bump minor version * 3170 language portion of language code is case insensitive (#3171) * 3170 language portion of language code is case insensitive * 3170 adding changelog * 3170 house keeping Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info: * Add version enum * Bump hapi version to 5.6.3 * Add version enum * Add changelog folder and version.yaml * Patch vulnerability, add changelog * AuthorizationInterceptor concurrency failure (#3528) * Fix #3256 - AuthorizationInterceptor concurrency failure * Test fixes * Add backport info * Fix test for lang level 8 * Bump hapi * License updates * Add release pipeline * remove checkstyle from old version * swap jdk for build * Couple removals for arbitrary failures * disabling tests for this next 5_6 release because we shoot from the hip here * Updating version to: 5.6.5 post release. * add new folder * fix versionenum * remove unreleased versions * Bring back into line Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: TipzCM <leif.stawnyczy@gmail.com> Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> Co-authored-by: IanMMarshall <49525404+IanMMarshall@users.noreply.github.com> Co-authored-by: ianmarshall <ian@simpatico.ai> Co-authored-by: Joanne Mendoza <joannemmendoza@gmail.com> Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: katie_smilecdr <katie@smilecdr.com> Co-authored-by: James Agnew <jamesagnew@gmail.com> Co-authored-by: markiantorno <markiantorno@gmail.com>
Qingyixia
pushed a commit
that referenced
this pull request
Jul 22, 2022
* 3138 externalized binary packages (#3139) * Add test and impl * Add changelog * Fix test * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/5_6_0/3138-support-externalized-binaries.yaml * add beans to test configs * Typo * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/IBinaryStorageSvc.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/binstore/NullBinaryStorageSvcImpl.java Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> * 3131 - Added support for the lookup operation in the Remote Terminology code (#3134) * Remove leading underscores from identifiers (#3146) * Version bump * License files * version.yaml * Add executeRawSql() method to Migrator (#3183) * Add implementation, add test * Add javadoc * Add another helper function * Bump version * 3153 update unknowncodesystemwarningvallidationsupport to have configurable severities (#3155) * 3153 updating the unknowncodesystemwarningvalidationsupport class * 3153 updating version for smile * 3153 update broken tests * 3153 adding log * 3153 cleanup * 3153 cleanup Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info * Avoid creating ResourcePersistentId for placeholder resources with null ID (#3158) * Add check before mapping storage ID to resource ID in TransactionDetails. * Add change log. * Changed to instead prevent creation of ResourcePersistentId with null ID value. * Changed to instead prevent ResourcePersistentId being created with null resource ID. Co-authored-by: ianmarshall <ian@simpatico.ai> * Fix bug loading packages in non-database mode (#3199) * Add implementation * Add changelog * Add backports * 3164 updating code review points (#3165) * 3164 updating code review points * 3164 updating code review points Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add executeRawSqlStub (#3203) Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> * Add new version * begin with failing test * fix bug * change log * change log * Add backport informationm * begin with failing test * fix issue * change log * code review * Add backport info. Add folder * fixed * Add test * Update test * Add backport info * Bump minor version * 3170 language portion of language code is case insensitive (#3171) * 3170 language portion of language code is case insensitive * 3170 adding changelog * 3170 house keeping Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> * Add backport info: * Add version enum * Bump hapi version to 5.6.3 * Add version enum * Add changelog folder and version.yaml * Patch vulnerability, add changelog * AuthorizationInterceptor concurrency failure (#3528) * Fix #3256 - AuthorizationInterceptor concurrency failure * Test fixes * Add backport info * Fix test for lang level 8 * Bump hapi * License updates * Add release pipeline * remove checkstyle from old version * swap jdk for build * Couple removals for arbitrary failures * disabling tests for this next 5_6 release because we shoot from the hip here * Updating version to: 5.6.5 post release. * add new folder * fix versionenum * remove unreleased versions * Bring back into line Co-authored-by: Kevin Dougan SmileCDR <72025369+KevinDougan-SmileCDR@users.noreply.github.com> Co-authored-by: michaelabuckley <michaelabuckley@gmail.com> Co-authored-by: TipzCM <leif.stawnyczy@gmail.com> Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local> Co-authored-by: IanMMarshall <49525404+IanMMarshall@users.noreply.github.com> Co-authored-by: ianmarshall <ian@simpatico.ai> Co-authored-by: Joanne Mendoza <joannemmendoza@gmail.com> Co-authored-by: Joanne Mendoza <joanne@smilecdr.com> Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: katie_smilecdr <katie@smilecdr.com> Co-authored-by: James Agnew <jamesagnew@gmail.com> Co-authored-by: markiantorno <markiantorno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated UnknownCodeSystemWarningValidationSystem to allow specifying specific issue severity
Updated to allow warnings to be displayed as warnings instead of failing as errors
Added changelog and updated tests