Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce maximum chunk size in bulk export #5800

Merged
merged 10 commits into from
Apr 1, 2024

Conversation

jamesagnew
Copy link
Collaborator

This PR adds a new setting which reduces the maximum file size and working chunk size for bulk export files

Copy link

github-actions bot commented Mar 23, 2024

Formatting check succeeded!

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending comments. Not too in love with the multi consumer API but i cant think of anything clearer offhand. Works for me.

@jamesagnew jamesagnew merged commit 6ce3b17 into master Apr 1, 2024
63 of 64 checks passed
@jamesagnew jamesagnew deleted the ja_20240309_limit_bulk_export_chunk_size branch April 1, 2024 13:28
codeforgreen pushed a commit that referenced this pull request Apr 8, 2024
* Limit bulk export chunk size

* Cleanup

* Work on tests

* Working

* Add some docs

* Address revuew comments

* Spotless

* Test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants