Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDM expansion doesn't work when using the :mdm qualifier in query string #5803

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

epeartree
Copy link
Collaborator

@epeartree epeartree commented Mar 26, 2024

When using the :mdm parameter qualifier with the _id search parameter, the fhir endpoint only returns the Resource with the id matching the value provided with _id SP.

what was done:

  • added failing test;
  • setting the mdmExpand flag on the TokenParam when qualifier ':mdm' is present
  • added changelog.

closes #5802

Copy link

github-actions bot commented Mar 26, 2024

Formatting check succeeded!

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.40%. Comparing base (497b9f2) to head (cb57417).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5803      +/-   ##
============================================
+ Coverage     83.39%   83.40%   +0.01%     
- Complexity    26927    26936       +9     
============================================
  Files          1681     1681              
  Lines        103965   104007      +42     
  Branches      13189    13196       +7     
============================================
+ Hits          86702    86752      +50     
+ Misses        11613    11604       -9     
- Partials       5650     5651       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epeartree epeartree merged commit 2f9693a into master Mar 27, 2024
66 checks passed
@epeartree epeartree deleted the EP_mdm_expansion branch March 27, 2024 14:12
codeforgreen pushed a commit that referenced this pull request Apr 8, 2024
…ing (#5803)

* wip

* cleaning up test

* adding changelog and passing spotless.

---------

Co-authored-by: peartree <etienne.poirier@smilecdr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDM expansion doesn't work when using the :mdm qualifier in query string
2 participants