Ensure CanonicalizedSubscription reflects StorageSettings.isCrossPartitionSubscriptionEnabled if it's true. Make that setting is true by default #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukedegruchy
commented
Mar 28, 2024
•
lukedegruchy
commented
- Ensure CanonicalizedSubscription is set to StorageSettings.isCrossPartitionSubscriptionEnabled() if it's true
- Ensure StorageSettings.isCrossPartitionSubscriptionEnabled() is true by default
- Add a new test and fix other tests to use the new SubscriptionCanonicalizer constructor.
- Deprecate FhirPatch rule
|
Formatting check succeeded! |
…scription module with the correct config for cross partition enabled.
…cription module uses the JpaStorageSettings cross partition enabled setting. Fix all compile errors. TODOs for tests to add and known test failures.
…eSettings for canonicalizer.
…ageSettings and deprecate it. Cleanup logs and TODOs.
lukedegruchy
changed the title
lukedegruchy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5810 +/- ##
============================================
- Coverage 83.39% 83.33% -0.07%
- Complexity 26927 26947 +20
============================================
Files 1681 1686 +5
Lines 103965 104134 +169
Branches 13189 13218 +29
============================================
+ Hits 86702 86780 +78
- Misses 11613 11707 +94
+ Partials 5650 5647 -3 ☔ View full report in Codecov by Sentry. |
TipzCM
approved these changes
Apr 8, 2024
...age/src/main/java/ca/uhn/fhir/jpa/subscription/match/registry/SubscriptionCanonicalizer.java
Show resolved
Hide resolved
hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/interceptor/auth/RuleImplPatch.java
Show resolved
Hide resolved
...test-r4/src/test/java/ca/uhn/fhir/jpa/partition/PartitionedSubscriptionTriggeringR4Test.java
Outdated
Show resolved
Hide resolved
.../java/ca/uhn/fhir/jpa/subscription/module/subscriber/SubscriptionMatchingSubscriberTest.java
Outdated
Show resolved
Hide resolved
lukedegruchy
deleted the
ld-20240328-subscription-partition-patient-id-does-not-trigger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.