reduction step failing fails jobs #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
TipzCM
requested review from
michaelabuckley,
jamesagnew and
tadgh
as code owners
added 2 commits
April 8, 2024 10:42
davidraeside
approved these changes
Apr 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5831 +/- ##
============================================
- Coverage 83.39% 83.33% -0.06%
- Complexity 26927 26942 +15
============================================
Files 1681 1686 +5
Lines 103965 104123 +158
Branches 13189 13218 +29
============================================
+ Hits 86702 86772 +70
- Misses 11613 11700 +87
- Partials 5650 5651 +1 ☔ View full report in Codecov by Sentry. |
codeforgreen
pushed a commit
that referenced
this pull request
Apr 8, 2024
* adding a catch for failing reduction step * spotless * added changelog --------- Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-mbp.home>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5828