Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription query maximum number of results #678

Merged
merged 2 commits into from
Jun 25, 2017

Conversation

javajeff
Copy link
Collaborator

Contains a critical fix for rest hook subscriptions. It currently only searches the default max number of results which is 10. This occurs in two locations:

  1. When the server starts up it reads in all active subscriptions
  2. When evaluating subscription criteria
    We need to set the limit higher, in this case 10000, but a higher number can be used.

Contains an enhancement to validate the subscription criteria before performing an update or delete. This will prevent the FHIR server from making subscription queries it cannot parse. If there is an error in the criteria, a bad input return code is returned before the server saves a subscription.

Also removed some unneeded web.xml file templates.

…d fhir criteria validation before create/update, added dstu2 configurations
@javajeff javajeff changed the title Validate subscription criteria Fix subscription query maximum number of results Jun 23, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 76.814% when pulling 0b578e3 on validate-subscription-criteria into 7937877 on master.

@jamesagnew jamesagnew merged commit 4eb9f2d into master Jun 25, 2017
jamesagnew added a commit that referenced this pull request Jun 25, 2017
@javajeff javajeff deleted the validate-subscription-criteria branch June 27, 2017 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants