Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isBase64 is not available on Android (Use java.util.Base64) #1046

Closed
vitorpamplona opened this issue Dec 21, 2022 · 1 comment · Fixed by #1079
Closed

isBase64 is not available on Android (Use java.util.Base64) #1046

vitorpamplona opened this issue Dec 21, 2022 · 1 comment · Fixed by #1079
Assignees
Labels
enhancement New feature or request

Comments

@vitorpamplona
Copy link
Contributor

vitorpamplona commented Dec 21, 2022

The new check for Base64 strings is not available on Android:

This is similar to hapifhir/hapi-fhir#1441

Android's boot classpath overrides Apache Commons Codec with an older version than the 1.15 referenced by this project. Google doesn't seem to be enticed to fix this. The available class is here

There are two possible solutions:

  1. Use java.util.Base64 (added in Java 8 to replace the need for Apache Commons Codec)
  2. Use the old Base64.isArrayByteBase64(toCheck.getBytes()) method

Which one is preferred?

@JPercival
Copy link
Contributor

@jamesagnew @brynrhodes - This goes hand-in-hand with some hapi-fhir changes to support Android:
hapifhir/hapi-fhir#4070

vitorpamplona added a commit to google/android-fhir that referenced this issue Jan 10, 2023
* Migrating CQL Evaluator and its dependencies to 2.4 to fix #1733

* Evaluator 2.4's generate care plan returns an IBaseResource to prepare for R5.

* Migrates to evaluator 2.4

* Removes outdated antlr dependency fix of 2.4

* Forces Jackson 2.14.1 due to a dependency bug when using Gradle and the 2.13.4.1 version FasterXML/jackson-databind#3627

* Forces Jackson 2.14.1 due to a dependency bug when using Gradle and the 2.13.4.1 version FasterXML/jackson-databind#3627

* Fixing tests to match CQL-Evaluator's tests

* Spotless apply

* Force version of caffeine

* Forces HAPI and FHIR CORE to earlier versions due to hapifhir/org.hl7.fhir.core#1046

* deleting non existant r4b

* Fixing imports of the Benchmark module

* Moving common blocks to Dependencies.

* spotless apply
@dotasek dotasek self-assigned this Apr 11, 2023
@dotasek dotasek added the enhancement New feature or request label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants