updates for jdk21

[oliveregger]

running mvn clean install returns an error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (java-compile) on project org.hl7.fhir.utilities: Compilation failure
[ERROR] java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid'
[ERROR] at lombok.javac.JavacImportList.getFullyQualifiedNameForSimpleNameNoAliasing(JavacImportList.java:53)
[ERROR] at lombok.core.TypeResolver.typeRefToFullyQualifiedName(TypeResolver.java:60)
[ERROR] at lombok.javac.HandlerLibrary.handleAnnotation(HandlerLibrary.java:247)
[ERROR] at lombok.javac.JavacTransformer$AnnotationVisitor.visitAnnotationOnField(JavacTransformer.java:84)
[ERROR] at lombok.javac.JavacNode.traverse(JavacNode.java:135)

this is due to a lombok issue.
updating to the latest dependency fixes the problem.

a second error appeared during validation of tests:

Mockito cannot mock this class: class org.hl7.fhir.utilities.npm.FilesystemPackageCacheManager.

If you're not sure why you're getting this error, please open an issue on GitHub.

Java : 21
JVM vendor name : Homebrew
JVM vendor version : 21
JVM name : OpenJDK 64-Bit Server VM
JVM version : 21
JVM info : mixed mode, sharing
OS name : Mac OS X
OS version : 14.0

You are seeing this disclaimer because Mockito is configured to create inlined mocks.
You can learn about inline mocks and their limitations under item #39 of the Mockito class javadoc.

Underlying exception : org.mockito.exceptions.base.MockitoException: Could not modify all classes [class org.hl7.fhir.utilities.npm.FilesystemPackageCacheManager, class org.hl7.fhir.utilities.npm.BasePackageCacheManager, class java.lang.Object, interface org.hl7.fhir.utilities.npm.IPackageCacheManager]

this can be fixed also when updating to the latest version of byte_buddy_version.

the build and all tests run then through:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for HL7 Core Artifacts 6.1.14:
[INFO]
[INFO] HL7 Core Artifacts ................................. SUCCESS [ 1.028 s]
[INFO] org.hl7.fhir.utilities ............................. SUCCESS [ 19.400 s]
[INFO] org.hl7.fhir.dstu2 ................................. SUCCESS [ 13.824 s]
[INFO] org.hl7.fhir.dstu2016may ........................... SUCCESS [ 20.605 s]
[INFO] org.hl7.fhir.dstu3 ................................. SUCCESS [ 23.945 s]
[INFO] org.hl7.fhir.r4 .................................... SUCCESS [ 36.538 s]
[INFO] org.hl7.fhir.r4b ................................... SUCCESS [01:29 min]
[INFO] org.hl7.fhir.r5 .................................... SUCCESS [01:57 min]
[INFO] org.hl7.fhir.convertors ............................ SUCCESS [ 29.702 s]
[INFO] org.hl7.fhir.validation ............................ SUCCESS [04:50 min]
[INFO] org.hl7.fhir.validation.cli ........................ SUCCESS [ 27.946 s]
[INFO] org.hl7.fhir.report ................................ SUCCESS [ 9.973 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:20 min
[INFO] Finished at: 2023-10-10T20:57:50+02:00
[INFO] -----------------------------------------------------------------------

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1e1e7de) 11.56% compared to head (ba11aa3) 11.56%.
Report is 5 commits behind head on master.

❗ Current head ba11aa3 differs from pull request most recent head 2236543. Consider uploading reports for the commit 2236543 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1457   +/-   ##
=========================================
  Coverage     11.56%   11.56%           
- Complexity    29586    29588    +2     
=========================================
  Files          2145     2145           
  Lines        662905   662905           
  Branches     196036   196036           
=========================================
+ Hits          76680    76683    +3     
+ Misses       558145   558143    -2     
+ Partials      28080    28079    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dotasek]

The changes look fine; please take a look at #1462; it contains a minor change that will get the license check to pass. Cherry picking that change will get this MR to pass.

[dotasek]

#1462 has been merged; this PR is no longer necessary.