Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hapi v21 and node v18, drop hapi v19 and node v12, test ESM support #488

Merged
merged 2 commits into from Oct 10, 2022
Merged

Support hapi v21 and node v18, drop hapi v19 and node v12, test ESM support #488

merged 2 commits into from Oct 10, 2022

Conversation

devinivy
Copy link
Member

  • Support and test on hapi v21, drop support for hapi v19 and below.
  • Support and test on node v18, drop support for node v12 and below.
  • Test ESM support.
  • Utilize some node v14+ new syntax.

If this looks good, this will go out as bell v13.

@devinivy devinivy added breaking changes Change that can breaking existing code test Test or coverage dependency Update module dependency labels Oct 10, 2022
@devinivy devinivy added this to the 13.0.0 milestone Oct 10, 2022
Nargonath
Nargonath approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work Devin.

@devinivy devinivy merged commit a216828 into v13 Oct 10, 2022
@devinivy devinivy deleted the node-18-hapi-21 branch October 10, 2022 12:14
@devinivy devinivy self-assigned this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nargonath Nargonath Nargonath approved these changes

Assignees

@devinivy devinivy

Labels
breaking changes Change that can breaking existing code dependency Update module dependency test Test or coverage
Projects
None yet
Milestone
13.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devinivy @Nargonath